Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyTagsToComments() always creates HTML versions of the tags even if option_tags_html=false #221

Closed
ben-xo opened this issue Dec 24, 2019 · 2 comments
Closed

CopyTagsToComments() always creates HTML versions of the tags even if option_tags_html=false #221

ben-xo opened this issue Dec 24, 2019 · 2 comments

Comments

@ben-xo
Copy link
Contributor

ben-xo commented Dec 24, 2019

I have submitted #220 to address this.
@ben-xo
Copy link
Contributor Author

ben-xo commented Dec 24, 2019

This patch doesn't address the problem that CopyTagsToComments() re-html-izes every comment it copies, even if the tags array already had an html-ized version, meaning that some work is done twice.

@JamesHeinrich
Copy link
Owner

Thanks, merged.

Feel free, if you're so inspired, to submit more fixes to fix the rest of the problem as you described.

@ben-xo ben-xo mentioned this issue Dec 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ben-xo @JamesHeinrich