Bugfix/copy tags to comments optional entities #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to disable the creation of HTML versions of tags when they were originally disabled for $getID3->analyze() as well, saving time and memory
…for $option_tags_html to getid3_lib::CopyTagsToComments()
…o that they always obey the configuration chosen for getID3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getid3_lib::CopyTagsToComments($info)spends time creating HTML versions of tags, even if the instance of getID3 that created the$infoarray had the optionoption_tags_htmlset to false.This changeset adds an optional
$option_tags_html(defaulting to true) togetid3_lib::CopyTagsToComments(), and then an instance method$getID3->CopyTagsToComments()which passes the option in as it was originally set.The demo files are also updated to match, although the change should be fully backward compatible.