Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo for genre name and extension of the exception list for genre parser #223

Closed
calliostro opened this issue Dec 28, 2019 · 2 comments
Closed

Comments

@calliostro
Copy link

Hi James Heinrich,

In module.tag.id3v2.php:526 this is a typo, isn't it? You are searching for the genre "Rock/Rock", but I think you meant "Folk/Rock".

Could this list of exceptions be made configurable? If I want to use the tags from Discogs, I would have to add "RnB/Swing" and "Funk / Soul" (with spaces) to the list.

https://www.discogs.com/en/genre/funk+%2F+soul
https://www.discogs.com/en/style/rnb%2Fswing

Many greetings
Denis

@JamesHeinrich
Copy link
Owner

Yes, "Rock/Rock" would be a typo. But actually in looking up the references, "Folk-Rock" is the proper version with a hyphen not a slash, so it shouldn't be part of this list anyways.

I have changed the code section slightly by putting the list of exceptions in an array that's easily extended (and should help avoid typos like "Rock/Rock"), and added in the three slashed examples I found from Discogs

@calliostro
Copy link
Author

Many thanks for the quick solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants