Some PDF files crashes

[tomswinkels]

With some PDF files the plugin crashes.

When i remove the '&' caracter in the getid3_pdf class the file works, but other files also work as well with the '&' character.

$info = &$this->getid3->info; to $info = $this->getid3->info;

See the attach file.
formulier-taak-herexamen.pdf

[JamesHeinrich]

Fixed in 80c5578

[tomswinkels]

@JamesHeinrich can you make a new release with that fix?

[zerocrates]

Even with this change I'm still seeing infinite looping on at least some PDFs. ftell seems to move all over the place so it's a higher level than just this inner loop, I guess.

[JamesHeinrich]

Do you have a non-sensitive PDF that shows this problem you can send me (info@getid3.org) for testing?

[zerocrates]

I'm checking with the user I got my example from; I'll pass it along if they give me a thumbs-up to send it.

[JamesHeinrich]

Thanks for the sample file, I can at least reproduce the infinite-loop behaviour. I may not be able to look at the issue for a couple days but I'll investigate what's causing the problem and let you know.

[JamesHeinrich]

So it turns out the PDF specification is a little more "flexible" (read: poorly standardized) than I had thought and the existing parsing code was not finding what it was looking for. I have rewritten that section and it should be a bit more robust now.
a5f31b3
Please reopen this ticket if you find more PDFs that cause problems.