ValueError: strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack)

[paulijar]

I got a report from an end user that a few of his files are breaking the file scanning. I got also a sample file which I shall email shortly. The error message indicates that the scanning is terminated at

getID3/getid3/module.tag.id3v2.php

Line 999 in a5f31b3

$frame_terminatorpos = strpos($parsedFrame['data'], $frame_textencoding_terminator, $frame_offset);

because of the reason shown in the issue title. That is, the $frame_offset goes beyond the end of the target data buffer.

This actually terminates the file analysis only when PHP 8.0 is used, because there, the platform throws a ValueError on invalid argument value. On PHP 7.x, this just emits a warning and the file analysis continues and returns valid-looking data.

The original report is here: owncloud/music#856

[JamesHeinrich]

Thanks for the sample file, fixed in 897de38.

The file has a badly-written "USLT" (lyrics) frame. The frame requires at a minimum 5 bytes (1x encoding, 3x language, 1x description/data terminator) even if the frame contains no actual data, but the sample file has the frame stop after the encoding byte. I have added a check for sufficient data before attempting to parse it.

[paulijar]

Thanks! Your response time was astonishing as always. 🎉