Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw tags for mp4 audio read as 0 second #371

Open
lachlan-00 opened this issue Mar 16, 2022 · 7 comments
Open

raw tags for mp4 audio read as 0 second #371

lachlan-00 opened this issue Mar 16, 2022 · 7 comments
Labels
bug A bug report enhancement

Comments

@lachlan-00
Copy link

Just referencing an open issue we have.
ampache/ampache#3196 (comment)

I'm not sure about the specifics of mp4 audio but the playtime_seconds is being read as 0 in the raw tags

I do still have the reference file if you want to check it out.

@JamesHeinrich
Copy link
Owner

I would need to see a sample file, please.

@JamesHeinrich
Copy link
Owner

I took a look at your sample file and it seemed to work as expected, playtime_seconds shows 15.34

@lachlan-00
Copy link
Author

okay let me dig further then.

@lachlan-00
Copy link
Author

lachlan-00 commented Apr 1, 2022

Using demo.basic.php and putting the file in the same folder i still get 0 for playtime_seconds.
Is there a non-default setting that's needed to return the time?

I also see that quicktime files are only returning the second value in arrays. I can't seem to track down where this is being overwritten in module.audio-video.quicktime.php

edit

i've run with pph 7.4, 8.0 and 8.1 as well just to see if there's anything not being read

@lachlan-00 lachlan-00 reopened this Apr 1, 2022
@JamesHeinrich
Copy link
Owner

JamesHeinrich commented Apr 1, 2022

I took a look at your sample file and it seemed to work as expected, playtime_seconds shows 15.34

I think I was sloppy and looked at the wrong sample file :(
I concur that it's returning a playtime of zero. I will investigate further.

@JamesHeinrich JamesHeinrich added bug A bug report enhancement and removed sample needed labels Apr 1, 2022
@JamesHeinrich
Copy link
Owner

JamesHeinrich commented Apr 1, 2022

Your sample file is a "fragmented MP4" (more useful for streaming) where data is stored in many small independent segments rather than one large segment. I haven't been able to find useful documentation as to the exact structure of some of the crucial structures, notably
tfhd // Track Fragment HeaDer box
mfhd // Movie Fragment HeaDer box
mvex // MoVie EXtends box
If someone can find some appropriate documentation showing the byte structure of these and related please let me know.

JamesHeinrich added a commit that referenced this issue Apr 1, 2022
@lachlan-00
Copy link
Author

Thank you for taking the time to look again.

I'll see if I can find out more about them and report anything back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report enhancement
Projects
None yet
Development

No branches or pull requests

2 participants