-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Added PHPDoc type hints, encoding issues, errors reported by IDE and PHPStan #143
[WIP] Added PHPDoc type hints, encoding issues, errors reported by IDE and PHPStan #143
Conversation
StudioMaX
commented
Feb 4, 2018
- Fixed charset in changelog.txt
- Added .editorconfig to not mix-up different new line separators and spacing created by different editors
- PHPDoc with type hints for the most methods
- Fixed some issues reported by IDE and PHPStan
…pacing created by different editors
@JamesHeinrich Travis says (https://travis-ci.org/JamesHeinrich/getID3) that it was disabled on this project, why? I found a lot of errors after implementing the PHPDoc type hinting and launching the PHPStan analyzer, and most of them probably can be fixed with your help. Can you enable it back, please? |
Update getID3 version string for changes made in #143
@StudioMaX: Travis CI was emailing me daily about something failing, and I didn't know who signed me up for it, so I turned it off. I've re-enabled it for you. For example, it blandly says Build #48 is still failing |
@StudioMaX: Packagist.org also emailed me as follows, since I assume it's related to whatever you're doing perhaps you can address that issue as well:
|
Update getID3 version string for changes made in JamesHeinrich#143