Fix Error: Trying to access array offset on value of type bool (on li…

[ben-xo]

…ne 1791 of getID3/module.audio.mp3.php)

[JamesHeinrich]

Can you provide a sample file that would trigger MPEGaudioHeaderValid getting called with $rawarray not being an array?

[ben-xo]

This was the one from my testing, and only on PHP7.4 https://gorich.org/NitaaiMeditation.mp4

[JamesHeinrich]

The fact that it only happens on PHP 7.4 seems significant. I don't have ready access to a 7.4 test environment right at the moment, would you be able to trace through and see where/why/how MPEGaudioHeaderValid is getting called with $rawarray not being an array, and why that would happen on 7.4 but not earlier versions?

I don't want to simply mask the error when there may be a more significant problem lurking elsewhere.

[ben-xo]

I'll see what I can do.

[ben-xo]

This is the stack trace, right before it crashes

dir2cast.php (suspended at line breakpoint)	
	/Users/ben/Documents/workspace/dir2cast test/getID3/module.audio.mp3.php.getid3_mp3::MPEGaudioHeaderValid(): lineno 1791	
	/Users/ben/Documents/workspace/dir2cast test/getID3/module.audio-video.quicktime.php.getid3_quicktime->QuicktimeParseAtom(): lineno 1457	
	/Users/ben/Documents/workspace/dir2cast test/getID3/module.audio-video.quicktime.php.getid3_quicktime->Analyze(): lineno 74	
	/Users/ben/Documents/workspace/dir2cast test/getID3/getid3.php.getID3->analyze(): lineno 629	
	/Users/ben/Documents/workspace/dir2cast test/dir2cast.php.getID3_Podcast_Helper->appendToItem(): lineno 165	
	/Users/ben/Documents/workspace/dir2cast test/dir2cast.php.MP4_RSS_Item->appendToChannel(): lineno 420	
	/Users/ben/Documents/workspace/dir2cast test/dir2cast.php.Locking_Cached_Dir_Podcast->generate(): lineno 761	
	/Users/ben/Documents/workspace/dir2cast test/dir2cast.php.Locking_Cached_Dir_Podcast->generate(): lineno 1012	
	/Users/ben/Documents/workspace/dir2cast test/dir2cast.php.{main}(): lineno 1511	

at this point, MPEGaudioHeaderDecode is returning false - that code path is possible if $this->fread(4) returns fewer than 4 bytes.

[ben-xo]

Stepping through the code, the file pointer for the mp4 file is at the end of the file when this code is called, so that's why it returns less than 4 bytes.