When parsing Quicktime subatoms, check the data length against... #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected length. Sometimes a container will contain slightly more data than expected, enough to read the header of an atom which is actually outside of the container. This guards against that. (The atom will be correctly read as parallel to the container in the next pass). Example: a 'moov' atom with the first 8 bytes of a subsequent 'uuid' atom that appears afterward.
|
Is this related to the mdat issue I came across here: https://github.com/JamesHeinrich/getID3/issues/382? Where the call to QuicktimeParseAtom is reading the atom data with the full atom size, versus a read length of atom size - header size? |
yes, it could be. see #226 - my comment here suggests that there may be such a bug - but I didn't find it at the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...the expected length.
Sometimes a container will contain slightly more data than expected, enough to read the header of an atom which is actually outside of the container. This guards against that. (The atom will be correctly read as parallel to the container in the next pass).
Example: a 'moov' atom with the first 8 bytes of a subsequent 'uuid' atom that appears afterward.
Addresses #226