Fix missing cover art in .m4a #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to provide a sample file that causes a problem here (that would be fixed by your suggested change)? I would like to see how it's breaking. |
|
Test file: silence.zip Image attached to file using kid3-cli with |
JamesHeinrich
added a commit
that referenced
this pull request
Mar 4, 2020
#233 The same attached image could appear as multiple entries in [comments][picture]
|
Thanks for the sample file, it was helpful in testing. Your change makes sense, but when applied it reveals something else that shouldn't be happening, I've merged your change and made the additional change in ec929d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More strict requirements for duplicate skipping, fixes owncloud/music#743