fixed possible endless loop processing png file with wrong filesize #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm processing a list of files that I read from an external url and saving them with the same filename on disk (temp name only for processing). Since the library is using
filesize
which is cached, the png parser goes into an endless loop when dealing with a smaller file than the previous one.I have few options to solve it outside the library like using a different name per file or calling
clearstatcache
before every call to the library, but I still think it should not be possible to reach an endless loop in the code.Below is an example code that should trigger the endless loop. big-file.png should be bigger in size than small-file.png.
My fix checks that
fread
returns data and breaks with a warning if it returns empty.