Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turkish lira currency code #277

Closed
wants to merge 1 commit into from
Closed

Update Turkish lira currency code #277

wants to merge 1 commit into from

Conversation

lebedevsergey
Copy link

@lebedevsergey lebedevsergey commented Dec 9, 2020

Since 2005 Turkish lira currency code has changed from TRL to TRY, let's keep it up to date!

@StudioMaX
Copy link
Collaborator

Not sure if it will be correct to just replace the old currency code with the new one, as this will break compatibility with the old tags, in which the old currency code was specified. Perhaps it is worth specifying both the old and the new code for the same currency? Or change it to something like "Liras (before 2005)". @JamesHeinrich what do you think?

JamesHeinrich added a commit that referenced this pull request Dec 9, 2020
@JamesHeinrich
Copy link
Owner

JamesHeinrich commented Dec 9, 2020

I have added "TRY" for the new Turkish Lira, but the old "TRL" should not be removed.
265b78c

edit: exactly as StudioMaX said while I was making the change :)

@lebedevsergey
Copy link
Author

Well, had had the same idea - to keep the old code when adding the new one. But then I thought that there are definitely a lot of outdated currency codes, and they are not present in getID3 source.
Anyway, you've made your decision, thanks for this update

@JamesHeinrich
Copy link
Owner

If you care to present a list of outdated currency codes that are not present in getID3's list I don't mind including them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants