Replace preg_match to strpos() while defining a temporary directory #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list using `strpos` instead of a regular expression This also fixes the problem with rarely used paths like "/foo/bar#baz:/tmp", since # character is not escaped by preg_quote until PHP 7.3 (https://bugs.php.net/bug.php?id=75355)
StudioMaX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the path to the temporary directory is in the open_basedir list using
strposinstead of a regular expressionThis also fixes the problem with rarely used paths like "/foo/bar#baz:/tmp", since # character is not escaped by preg_quote until PHP 7.3 (https://bugs.php.net/bug.php?id=75355). Sample: https://3v4l.org/N0h1f