Work around divide by zero bug in MPEG-2 aspect ratio #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9ce8040 I introduced a divide-by-zero bug into the aspect ratio handling for MPEG-2 videos. In production at Wikipedia we've seen a few attempted uploads for files that trigger a divide by zero on the width, which either means corrupt files or something's wrong elsewhere. Unfortunately our logging doesn't include the files being uploaded, so I don't have a test case to analyze. But this workaround will at least avoid a fatal error that can't be caught. On our bug tracker: https://phabricator.wikimedia.org/T289189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9ce8040 I introduced a divide-by-zero bug into the aspect
ratio handling for MPEG-2 videos. In production at Wikipedia
we've seen a few attempted uploads for files that trigger a
divide by zero on the width, which either means corrupt files
or something's wrong elsewhere.
Unfortunately our logging doesn't include the files being
uploaded, so I don't have a test case to analyze. But this
workaround will at least avoid a fatal error that can't be
caught.
On our bug tracker: https://phabricator.wikimedia.org/T289189