imagejpeg(): Filename cannot be empty

[peterhough]

Hi James,

Experimenting with phpThumb today I came across the following issue:

phpthumb.class.php line 607

@$ImageOutFunction($this->gdimg_output, '', $this->thumbnailQuality);

From the PHP manual: http://php.net/manual/en/function.imagejpeg.php
bool imagejpeg ( resource $image [, string $filename [, int $quality ]] )
filename: To skip this argument in order to provide the quality parameter, use NULL.

Therefore I suggest altering:
phpthumb.class.php line 607 to:

@$ImageOutFunction($this->gdimg_output, NULL, $this->thumbnailQuality);

Cheers!
Pete

[JamesHeinrich]

Thanks. The same issue also happened on line 2904.

Fixed in this commit:
736effc

Historical note: back when this code was written (~2003) the PHP manual said use empty string for skipping the second parameter. The recommendation changed from "" to NULL sometime between 2006-Sep-02 and 2006-Sep-25:
http://web.archive.org/web/20060902214907/http://www.php.net/manual/en/function.imagejpeg.php
http://web.archive.org/web/20060925172257/http://www.php.net/manual/en/function.imagejpeg.php