Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding option #480

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Add encoding option #480

merged 1 commit into from
Jan 12, 2022

Conversation

humble-barnacle001
Copy link
Contributor

@humble-barnacle001 humble-barnacle001 commented Jan 11, 2022

Description

As discussed in #468 in #468 (comment)

Added a new option: encoding which allows to specify the encoding of the file in which data fetched is saved.

Testing Instructions

yarn test

Additional Notes

  • Need to add additional test to make sure that if user enters an encoding not in BufferEncoding it should throw an error.

@codecov-commenter
Copy link

Codecov Report

Merging #480 (1b01189) into dev (1ff2fad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           89        87    -2     
  Branches        23        22    -1     
=========================================
- Hits            89        87    -2     
Impacted Files Coverage Δ
src/lib.ts 100.00% <ø> (ø)
src/fetch.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff2fad...1b01189. Read the comment docs.

Copy link
Owner

@JamesIves JamesIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JamesIves JamesIves merged commit 5e9582c into JamesIves:dev Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants