Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deploying via SSH natively #459

Closed
JamesIves opened this issue Oct 10, 2020 · 2 comments
Closed

Support deploying via SSH natively #459

JamesIves opened this issue Oct 10, 2020 · 2 comments
Assignees
@JamesIves
Labels
planned 🕘 This feature is planned. version 4 Issues related to version 4 of this action.
Milestone
4.0.0

Comments

@JamesIves
Copy link
Owner

JamesIves commented Oct 10, 2020 •
edited
Loading

Originally posted by @tlienart in #454 (comment)

This issue involved bringing the SSH agent logic into this action so it no longer relies on a dependency.

For this change the action will no longer accept SSH: true/false but instead accept an SSH_KEY argument which will allow deployments. There should be a task that occurs during the runtime that configures the ssh agent within the ~/.ssh directory of the workspace. It should also be completely tested to prevent regressions.
@JamesIves JamesIves added this to the 4.0.0 milestone Oct 10, 2020
@JamesIves JamesIves added help wanted ❕ Extra attention is needed version 4 Issues related to version 4 of this action. hacktoberfest 🎃 Hacktoberfest related changes. labels Oct 10, 2020
@JamesIves JamesIves mentioned this issue Oct 10, 2020
Closed
@JamesIves
Copy link
Owner Author

I am hoping to have this wrapped up later this week.

@JamesIves JamesIves self-assigned this Dec 7, 2020
@JamesIves JamesIves added planned 🕘 This feature is planned. and removed hacktoberfest 🎃 Hacktoberfest related changes. help wanted ❕ Extra attention is needed labels Dec 7, 2020
@JamesIves
Copy link
Owner Author

This is now available in v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesIves JamesIves

Labels
planned 🕘 This feature is planned. version 4 Issues related to version 4 of this action.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@JamesIves