Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PRESERVE the default behavior #489

Closed
JamesIves opened this issue Nov 1, 2020 · 1 comment
Closed

Make PRESERVE the default behavior #489

JamesIves opened this issue Nov 1, 2020 · 1 comment
Assignees
@JamesIves
Labels
feature request ✨ New feature or request testing 🧪 This change is being tested. version 4 Issues related to version 4 of this action.
Milestone
4.0.0

Comments

@JamesIves
Copy link
Owner

JamesIves commented Nov 1, 2020 •
edited
Loading

Describe the bug

In version 4 the PRESERVE option should be eliminated, and instead made to be the defaulted behavior. It's confusing to the user currently and serves no purpose being behind a flag now that testing has concluded.

  • Make the stashing/applying work the same as before.
  • Improve the messaging to indicate to the user that this is occurring.

Additional Comments

This is in an effort to simplify the API for version 4.

  • In version 3.8.0 this will become the default option
  • In version 4 the PRESERVE flag will be removed entirely.
@JamesIves JamesIves added feature request ✨ New feature or request version 4 Issues related to version 4 of this action. labels Nov 1, 2020
@JamesIves JamesIves added this to the 4.0.0 milestone Nov 2, 2020
@JamesIves JamesIves changed the title Make PERSIST the default behavior Make PRESERVE the default behavior Nov 8, 2020
@JamesIves JamesIves modified the milestones: 4.0.0, 3.8.0 Nov 8, 2020
@JamesIves JamesIves linked a pull request Nov 17, 2020 that will close this issue
Defaults Preserve-LFS #503
Closed
@JamesIves JamesIves mentioned this issue Nov 17, 2020
Closed
@JamesIves JamesIves modified the milestones: 3.8.0, 4.0.0 Nov 18, 2020
@JamesIves JamesIves self-assigned this Nov 19, 2020
@JamesIves JamesIves added the testing 🧪 This change is being tested. label Nov 19, 2020
@JamesIves
Copy link
Owner Author

Resolved and in v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesIves JamesIves

Labels
feature request ✨ New feature or request testing 🧪 This change is being tested. version 4 Issues related to version 4 of this action.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Defaults Preserve-LFS JamesIves/github-pages-deploy-action
1 participant
@JamesIves