Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaults Preserve-LFS #503

Closed
wants to merge 2 commits into from
Closed

Defaults Preserve-LFS #503

wants to merge 2 commits into from

Conversation

JamesIves
Copy link
Owner

Description

Provide a description of what your changes do.

Makes LFS and Preserve options always toggled on. There shouldn't really be a reason you'd want these disabled.

Testing Instructions

Give us step by step instructions on how to test your changes.

Additional Notes

Anything else that will help us test the pull request.

@JamesIves JamesIves added the version 4 Issues related to version 4 of this action. label Nov 17, 2020
@JamesIves JamesIves added this to the 4.0.0 milestone Nov 17, 2020
@JamesIves JamesIves linked an issue Nov 17, 2020 that may be closed by this pull request
Make PRESERVE the default behavior #489
Closed
Pike
Pike reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with v4 now, right?

@JamesIves
Copy link
Owner Author

This conflicts with v4 now, right?

Indeed it does, closing this as obsolete.

@JamesIves JamesIves closed this Dec 8, 2020
@JamesIves JamesIves deleted the preserve-deprecate branch December 8, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike left review comments

Assignees
No one assigned
Labels
version 4 Issues related to version 4 of this action.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Make PRESERVE the default behavior
2 participants
@JamesIves @Pike