test: fix unit tests for arcgis adapter

src/adapters/arcgis-maps-sdk.adapter.spec.ts

@@ -5,13 +5,16 @@ import Point from "@arcgis/core/geometry/Point";
 import { TerraDrawAdapterStyling } from "../common";
 import Color from "@arcgis/core/Color";
 import MapViewScreenPoint = __esri.MapViewScreenPoint;
+import { createMockCallbacks } from "../test/mock-callbacks";
 
 jest.mock("@arcgis/core/views/MapView", () => jest.fn());
 jest.mock("@arcgis/core/geometry/Point");
 jest.mock("@arcgis/core/geometry/Polyline", () => jest.fn());
 jest.mock("@arcgis/core/geometry/Polygon", () => jest.fn());
 jest.mock("@arcgis/core/layers/GraphicsLayer");
 
+const remove = jest.fn();
+
 const createMockEsriMapView = () => {
 	return {
 		map: {
@@ -30,7 +33,7 @@ const createMockEsriMapView = () => {
 		})),
 		toScreen: jest.fn(() => ({ x: 0, y: 0 })),
 		toMap: jest.fn(() => ({ latitude: 0, longitude: 0 })),
-		on: jest.fn(),
+		on: jest.fn(() => ({ remove })),
 	} as unknown as MapView;
 };
 
@@ -54,6 +57,27 @@ describe("TerraDrawArcGISMapsSDKAdapter", () => {
 			expect(adapter.setCursor).toBeDefined();
 		});
 
+		it("initializes a GraphicsLayer with the internal ID and adds it to the mapView", () => {
+			const mockGraphicsLayer = { id: "xx" };
+			const lib = {
+				GraphicsLayer: jest.fn().mockReturnValue(mockGraphicsLayer),
+			} as any;
+			const mockMapView = createMockEsriMapView();
+			const adapter = new TerraDrawArcGISMapsSDKAdapter({
+				map: mockMapView,
+				lib,
+			});
+
+			expect(lib.GraphicsLayer).toHaveBeenCalledTimes(1);
+			expect(lib.GraphicsLayer).toHaveBeenCalledWith({
+				id: adapter["_featureLayerName"],
+			});
+			expect(mockMapView.map.add).toHaveBeenCalledTimes(1);
+			expect(mockMapView.map.add).toHaveBeenCalledWith(mockGraphicsLayer);
+		});
+	});
+
+	describe("register", () => {
 		it("adds drag and double-click event listeners", () => {
 			const mockMapView = createMockEsriMapView();
 			const adapter = new TerraDrawArcGISMapsSDKAdapter({
@@ -65,6 +89,8 @@ describe("TerraDrawArcGISMapsSDKAdapter", () => {
 
 			expect(adapter).toBeDefined();
 
+			adapter.register(createMockCallbacks());
+
 			expect(mockMapView.on).toHaveBeenCalledTimes(2);
 			expect(mockMapView.on).toHaveBeenNthCalledWith(
 				1,
@@ -77,24 +103,25 @@ describe("TerraDrawArcGISMapsSDKAdapter", () => {
 				expect.any(Function),
 			);
 		});
+	});
 
-		it("initializes a GraphicsLayer with the internal ID and adds it to the mapView", () => {
-			const mockGraphicsLayer = { id: "xx" };
-			const lib = {
-				GraphicsLayer: jest.fn().mockReturnValue(mockGraphicsLayer),
-			} as any;
+	describe("unregister", () => {
+		it("removes drag and double-click event listeners", () => {
 			const mockMapView = createMockEsriMapView();
+			const removeAll = jest.fn();
 			const adapter = new TerraDrawArcGISMapsSDKAdapter({
 				map: mockMapView,
-				lib,
+				lib: {
+					GraphicsLayer: jest.fn(() => ({ graphics: { removeAll } })),
+				} as any,
 			});
 
-			expect(lib.GraphicsLayer).toHaveBeenCalledTimes(1);
-			expect(lib.GraphicsLayer).toHaveBeenCalledWith({
-				id: adapter["_featureLayerName"],
-			});
-			expect(mockMapView.map.add).toHaveBeenCalledTimes(1);
-			expect(mockMapView.map.add).toHaveBeenCalledWith(mockGraphicsLayer);
+			expect(adapter).toBeDefined();
+
+			adapter.register(createMockCallbacks());
+			adapter.unregister();
+			expect(removeAll).toBeCalledTimes(1);
+			expect(remove).toBeCalledTimes(2);
 		});
 	});