-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated asyncTest usage in favor of assert.async for QUnit v1.16.0+ #9
Comments
I might be able to explore this in the next couple of weeks, if you're willing to accept a PR. |
Oh, question. Are you aiming for backward compatible support of pre-1.16, or are you okay with dropping support for that with this change (and possibly doing a major version bump)? If you did that, you could probably also not bother with the complicated fix to QUnit.push, either. |
Pinging @JamesMGreene. Can you please answer this question when you get a chance?
Thanks! |
Sorry for the [now usual] delay, Kevin. In all honesty, with the days of QUnit |
@JamesMGreene Works for me. |
You could test against 2.0.0-rc1: https://github.com/jquery/qunit/releases/tag/2.0.0-rc1 - not expecting any relevant changes till the final release. |
@JamesMGreene Now that 2.0.0 is out, should we look into this again? I think the simplest solution is a major version bump of this module and a full breaking change to just go into full QUnit 2.0 compatibility mode. |
@platinumazure: Yessir, that would be best. |
Thanks @JamesMGreene. I'll see if I can come up with a PR in the next couple of weeks, unless you beat me to it. |
The forthcoming QUnit
v1.16.0
will deprecateQUnit.asyncTest
in favor of a newassert.async()
approach (see qunitjs/qunit#653). This plugin should be updated to utilize this style of test as well.More importantly, this plugin must operate in a very non-standard way that could make it inviable to use the new
assert.async()
approach as a replacement for its current use ofQUnit.stop
/QUnit.start
. We should confirm that soon-ish as well in case we need to take an alternative approach... most likely we will just need to wrap thedone
callback in an indirect but globally available closure so it can be invoked when the child frame's test run finishes (i.e. as a replacement to qunit-composite.js#L86-L87).The text was updated successfully, but these errors were encountered: