Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated asyncTest usage in favor of assert.async for QUnit v1.16.0+ #9

Closed
JamesMGreene opened this issue Sep 16, 2014 · 9 comments

Comments

@JamesMGreene
Copy link
Owner

The forthcoming QUnit v1.16.0 will deprecate QUnit.asyncTest in favor of a new assert.async() approach (see qunitjs/qunit#653). This plugin should be updated to utilize this style of test as well.

More importantly, this plugin must operate in a very non-standard way that could make it inviable to use the new assert.async() approach as a replacement for its current use of QUnit.stop/QUnit.start. We should confirm that soon-ish as well in case we need to take an alternative approach... most likely we will just need to wrap the done callback in an indirect but globally available closure so it can be invoked when the child frame's test run finishes (i.e. as a replacement to qunit-composite.js#L86-L87).

@platinumazure
Copy link
Contributor

I might be able to explore this in the next couple of weeks, if you're willing to accept a PR.

@platinumazure
Copy link
Contributor

Oh, question. Are you aiming for backward compatible support of pre-1.16, or are you okay with dropping support for that with this change (and possibly doing a major version bump)?

If you did that, you could probably also not bother with the complicated fix to QUnit.push, either.

@platinumazure
Copy link
Contributor

Pinging @JamesMGreene. Can you please answer this question when you get a chance?

Oh, question. Are you aiming for backward compatible support of pre-1.16, or are you okay with dropping support for that with this change (and possibly doing a major version bump)?

Thanks!

@JamesMGreene
Copy link
Owner Author

Sorry for the [now usual] delay, Kevin. In all honesty, with the days of QUnit 1.x coming to an end and QUnit 2.0.0 forthcoming, it's probably best to just hold off on making any change like this until QUnit 2.x hits the scene. At that point, we can do a major version bump of this module as well and align it with QUnit 2.x.

@platinumazure
Copy link
Contributor

@JamesMGreene Works for me.

@jzaefferer
Copy link

You could test against 2.0.0-rc1: https://github.com/jquery/qunit/releases/tag/2.0.0-rc1 - not expecting any relevant changes till the final release.

@platinumazure
Copy link
Contributor

@JamesMGreene Now that 2.0.0 is out, should we look into this again? I think the simplest solution is a major version bump of this module and a full breaking change to just go into full QUnit 2.0 compatibility mode.

@JamesMGreene
Copy link
Owner Author

@platinumazure: Yessir, that would be best.

@platinumazure
Copy link
Contributor

Thanks @JamesMGreene. I'll see if I can come up with a PR in the next couple of weeks, unless you beat me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants