Fix blocking IO in JsonTextWriter.CloseAsync and add IAsyncDisposable #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Jun 16, 2022
| @@ -37,7 +37,20 @@ | |||
| namespace Newtonsoft.Json | |||
| { | |||
| public abstract partial class JsonWriter | |||
| #if HAVE_ASYNC_DISPOABLE | |||
There was a problem hiding this comment.
HAVE_ASYNC_DISPOABLE -> HAVE_ASYNC_DISPOSABLE
SimonCropp
added a commit
to SimonCropp/Argon
that referenced
this pull request
Feb 11, 2023
sousapedro
pushed a commit
to sousapedro/Newtonsoft.Json-for-Unity
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2694