Improve Self referencing loop exceptions on properties by including a recommendation #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wholeheartedly endorse this, I ran into this problem before and was scratching my head as to what could've been circular. And adding more information is always helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution to a self-referencing loop on most Properties is to add an ignore reference loop attribute, so the Exception may as well be there to tell novices how to most easily resolve it. Most devs running into this for the first time are likely to be surprised at the depth of Json.Net in having ways of handling this, and it may lead them to explore JsonProperty(ReferenceLoopHandling more deeply.