ulong.MaxValue parsing on .NET core #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want the lowest netstandard to be 1.0 I will probably support a higher version so that BigInteger works but I want to wait for a little bit to figure out exactly which one it should be. |
|
@JamesNK Did this end up getting fixed? I think you indicated as such on another issue. Can you point to the commit that fixes it? |
|
Not yet. It will probably be fixed in 9.0.2 |
azabluda
added a commit
to azabluda/InfoCarrier.Core
that referenced
this pull request
Aug 24, 2017
This fixes error "JSON integer 12345678901234567890 is too large or small for an Int64" in test Can_query_using_any_data_type run on .NET Core JamesNK/Newtonsoft.Json#892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, great that you're working on .NET core support!
I noticed the same issue as in #838, that ulong parsing is broken for values greater than what fits into a signed long.
I've added a test that demonstrates the problem and hacked together something that enables BigInteger parsing on netstandard11 and up.
How do you think would this be solved best? I fear this will trigger subtle bugs when porting from framework to core if not resolved.