Skip to content

Commit

Permalink
fix(validator): 🐛 fix markup of html validator errors
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNZL committed Jul 8, 2022
1 parent e039b09 commit d6733ee
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/options/validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,11 @@ export abstract class InputFieldValidator {

statusElement.setAttribute('id', `validating-input-${this.id}`);
statusElement.classList.add('validating-input-status');
statusElement.textContent = status;

this.input.insertAdjacentElement('beforebegin', statusElement);

Element.getInstance(`validating-input-${this.id}`, 'validator label')
.safelySetInnerHTML(status);
}

SaveButton.updateState(SaveButtonUpdates.Pending);
Expand Down Expand Up @@ -197,9 +199,11 @@ export abstract class InputFieldValidator {

errorElement.setAttribute('id', `invalid-input-${this.id}`);
errorElement.classList.add('invalid-input-error');
errorElement.textContent = error;

this.input.insertAdjacentElement('beforebegin', errorElement);

Element.getInstance(`invalid-input-${this.id}`, 'validator label')
.safelySetInnerHTML(error);
}

SaveButton.updateState(SaveButtonUpdates.Disable);
Expand Down

0 comments on commit d6733ee

Please sign in to comment.