Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone validation does not match Notion #252

Closed
JamesNZL opened this issue Sep 9, 2023 · 0 comments
Closed

Time zone validation does not match Notion #252

JamesNZL opened this issue Sep 9, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JamesNZL
Copy link
Owner

JamesNZL commented Sep 9, 2023

image

EST is a valid time zone according to my validation logic, but Notion doesn't accept it.

@JamesNZL JamesNZL added the bug Something isn't working label Sep 9, 2023
@JamesNZL JamesNZL self-assigned this Sep 9, 2023
@JamesNZL JamesNZL closed this as completed Jul 4, 2024
JamesNZL added a commit that referenced this issue Jul 4, 2024
… (#387)

* Fix import of assignments without due dates (#251) (#384)

* fix(canvas): 🐛 do not store absence of due date as unix epoch (#251)

* fix(import): 🐛 correctly import assignments without due dates to notion (#251)

* refactor(types): 🏷️ refactor type declaration files

change to regular typescript files

* fix(validator): 🐛 fix timezone validation (#252)

* build(notion): 👽 pin notion api version

* feat(notion): ✨ parse notion page properties

* feat(options): ✨ add `notion.importChanges` options

* fix(interface): 💄 properly hide segmented controls

* refactor(types): 🧑‍💻 strongly type `Storage` key methods

* docs(readme): 📝 update `readme`

* docs(readme): 📝 update advanced options heading size

* feat(import)!: ✨ update existing pages if assignment has changed (#385)

BREAKING CHANGE: This requires a new previously unheld capability on the integration. Existing users must reauthorise with Notion.

* build(actions): 💚 fix gulp build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant