Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainers and formatters #98

Open
JamesOwers opened this issue Nov 26, 2019 · 2 comments
Open

Trainers and formatters #98

JamesOwers opened this issue Nov 26, 2019 · 2 comments
Labels
design This pertains to design decisions priority: low requires_discussion Either a large change or changes functionality - discuss/debate before implementation
Milestone

Comments

@JamesOwers
Copy link
Owner

In general I think it's bad for usability for the Trainer classes to expect a weird formatter dictionary. I think we should look over the formatters and make them simpler / more general.

@JamesOwers JamesOwers added the requires_discussion Either a large change or changes functionality - discuss/debate before implementation label Nov 26, 2019
JamesOwers added a commit that referenced this issue Nov 26, 2019
Issues now written to address later: #98, #99, #100, #101, #102
issues #103 #104 #105 #106 #107 and #108
@apmcleod
Copy link
Collaborator

Related, it's unclear to me how general the trainers are. Probably, people creating their own models will just write their own training function to train how they like (at least, that's what I would do, since it's code I have written elsewhere before anyways). So then if the trainers are mainly for our baseline models, I think it's ok to have the format dict there, but we can discuss.

@apmcleod apmcleod added the design This pertains to design decisions label Nov 27, 2019
@JamesOwers
Copy link
Owner Author

The thing to consider first is whether to use pytorch lightning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This pertains to design decisions priority: low requires_discussion Either a large change or changes functionality - discuss/debate before implementation
Projects
None yet
Development

No branches or pull requests

2 participants