Removes signal handler for signal 28 (terminal resize signal) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup handler in this application was reponding to any and all process signals. The intent was for cleanup to run regardless of how the application was terminated (SIGTERM, SIGKILL, etc.). This behavior is inappropriate because certain signals, like 28, are simply used to notify the process of system events. Signal 28 (SIGWINCH) is used to signal a terminal resize event. It is likely the console blanking feature on the Pi is also sending this signal, which would cause a undesired shutdown of the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup handler in this application was reponding to any and all process signals.
The intent was for cleanup to run regardless of how the application was terminated
(SIGTERM, SIGKILL, etc.). This behavior is inappropriate because certain signals, like
28, are simply used to notify the process of system events. Signal 28 (SIGWINCH) is
used to signal a terminal resize event.
It is likely the console blanking feature on the Pi is also sending this signal, which
would cause a undesired shutdown of the program.