Fixed typo #20
Open
Fixed typo #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Fix Comment Regarding Potential NaN in SimpleRetention
Description:
Hello,
While going through the
SimpleRetentionclass in the module, I noticed a comment in the_get_Dmethod that seemed to have a minor inconsistency. The comment in question mentions:# this results in some NaN when n is much larger than mHowever, after analyzing the matrix operations, it appears that potential NaN values might arise when ( m ) (row index) is much larger than ( n ) (column index), specifically in the bottom-left triangle of the matrix.
This PR corrects the comment to:
# this results in some NaN when m is much larger than nSuch a change might seem minor, but it aids in clarity and correctness for any developer reading the code in the future.