This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Add new center position #9
Open
bastiengrignon
wants to merge
15
commits into
JamieLivingstone:master
Choose a base branch
from
bastiengrignon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons-update Adding new center position for the notification
Warning: as far as I can tell, only the dist/ has been updated, the src/ has not. |
@salamander2 Here is my code updated with new positions, updated README and demo html file |
@bastiengrignon Thanks! I haven't had time to do any stuff here, but I'll look at it in the next few days. |
@bastiengrignon okay. looks really good. I haven't tested it yet though. I think that you should update the Readme.MD to say that you are taking over maintenance of this app (or whatever it's called) since JLivingstone is AWOL. Just take it over. The original one points to you via the fork. |
Attempted to color code the themes in the listbox.
Co-authored-by: Bastien Grignon <41306995+bastiengrignon@users.noreply.github.com>
Improving demo. Add text of javascript command that is executed. Attempted to color code the themes in the listbox.
CONVERT function to arrow function CONVERT old var keyword to new const or let FIX missing semi-colon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.