fix: optional case for function overload previous node checking

JamieMason · Feb 26, 2024 · e75b139 · e75b139
1 parent 7d5dd71
commit e75b139
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/prefer-arrow-functions.spec.ts b/src/prefer-arrow-functions.spec.ts
@@ -439,6 +439,13 @@ const invalidAndHasSingleReturn = [
     output:
       'var withLoop = async () => async () => { for (i = 0; i < 5; i++) {}}',
   },
+
+  // function overloading - don't mislabel as overload
+  //   export { x as y }; has node.declaration === null - regression test for this case
+  {
+    code: 'export { _foo as bar }; export async function baz() { return false; }',
+    output: 'export { _foo as bar }; export const baz = async () => false;',
+  },
 ];
 
 const invalidAndHasSingleReturnWithMultipleMatches = [

diff --git a/src/prefer-arrow-functions.ts b/src/prefer-arrow-functions.ts
@@ -9,7 +9,7 @@ import {
 export default {
   meta: {
     docs: {
-      category: 'emcascript6',
+      category: 'ecmascript6',
       description: 'prefer arrow functions',
       recommended: false,
     },
@@ -110,7 +110,7 @@ export default {
       if (previousNode.type === 'TSDeclareFunction') return true;
       if (
         previousNode.type === 'ExportNamedDeclaration' &&
-        previousNode.declaration.type === 'TSDeclareFunction'
+        previousNode.declaration?.type === 'TSDeclareFunction'
       )
         return true;