ESLint 9 #34
Open
ESLint 9 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loucyx
commented
Apr 19, 2024
| @@ -492,14 +495,6 @@ const invalidAndHasBlockStatement = [ | |||
| code: 'async function foo(a) { console.log(3); }', | |||
| output: 'const foo = async (a) => { console.log(3); };', | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
The new RuleTester by ESLint fails if you have duplicated tests, so I had to remove a bunch of duplicated tests.
loucyx
commented
Apr 19, 2024
| ecmaFeatures: { jsx: false }, | ||
| ecmaVersion: 8, | ||
| sourceType: 'module', | ||
| // TODO: Remove this `languageOptions` once the tests are updated for flat config: |
There was a problem hiding this comment.
Once the tests are updated to support flat config, this can go back to the original values. The new default for RuleTester expects flat config tests.
loucyx
commented
Apr 19, 2024
| @@ -7,6 +7,9 @@ import { | |||
| } from './config'; | |||
| import rule from './prefer-arrow-functions'; | |||
|
|
|||
| // TODO: Remove this once Jest starts supporting modern JavaScript | |||
| globalThis.structuredClone ??= obj => JSON.parse(JSON.stringify(obj)); | |||
There was a problem hiding this comment.
Looks like ESLint now uses structuredClone so we need to "mock" it for Jest because Jest doesn't support that yet.
loucyx
commented
Apr 19, 2024
| @@ -193,8 +193,8 @@ export default { | |||
| }; | |||
|
|
|||
| const isPrototypeAssignment = (node) => { | |||
| return context | |||
| .getAncestors() | |||
| return sourceCode | |||
There was a problem hiding this comment.
These are the "key" changes, made following the official documentation.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (What)
Bare minimum changes to have ESLint 9 support. Ideally tests should be updated to test flat config and a lot of types should be added, but this is the minimum changes to support ESLint 9.
Justification (Why)
To give support to folks upgrading to ESLint 9.
How Can This Be Tested?
yarnto install the new dependencies.yarn testto run the tests.