-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shrinkpack command error failed to download @angular/platform-browser@2.0.0-rc.4 #58
Comments
I'm away at the moment but @5id I think this might be your slice on @ for scoped packages? |
One more detail: I tried it several times, by removing the repo and starting from scratch and it failed every time. But it fails on different |
I thought this might just be to do with scoped packages, but the following worked;
I will try to test the same on Windows. Other things of note
|
Hey @yaroslavya,
Can you upgrade npm and see if that sorts it? Thanks. |
I'm getting similar errors on Mine involves scoped packages also (in our case; private packages, so I can't provide a reproduction case), and it also errors on different packages each time it's run. It's not something like a request timeout or something is it? edit Same error on edit 2. Some investigation reveals the following lines in my (and the OP's) "@domain-group/fe-helper": {
"version": "2.2.2",
"from": "@domain-group/fe-helper@>=2.2.0 <3.0.0",
"resolved": "http://registry.npmjs.org/@domain-group/fe-helper/-/fe-helper-2.2.2.tgz"
},
"@domain-group/fe-lint-scss": {
"version": "1.0.2",
"from": "@domain-group/fe-lint-scss@>=1.0.1 <2.0.0",
"resolved": "file:node_shrinkwrap/@domain-group-fe-lint-scss-1.0.2.tgz"
}, There are two different
The interesting part is the edit 3: Checking out the code, I can see it's attempting to run the following commands:
But the folder edit 4: To clarify, the command I'm running is;
I'm going to re-run that again but prefixed with a edit 5: A-ha! Running |
I can't seem to reproduce the exact case above (where some fields in git clone https://github.com/preboot/angular2-webpack.git
cd angular2-webpack
npm cache clear
npm install
npm shrinkwrap
shrinkpack This succeeds. Note that the URLs for Now, run: rm -rf node_shrinkwrap # (1)
shrinkpack This fails. Note that at point |
Maybe it will shed some light, but my very first installation and shrinkpack was successful. Then I`ve deleted the node_modules folder and had this error I reported. I didnt get a chance to try it out yet. Will do this weekend. Maybe the updated npm will work just fine on windows. I will also try to clear the cache, maybe it does the trick. |
Similar problem here, I'm running the following commands: (1) fine and dandy till this point, then... (3) here shrinkpack fails with this:
this is on OSX 10.11.5, see node and npm version above. these exact commands worked without a hitch for months till last week. |
Thanks everyone, let's focus on https://github.com/preboot/angular2-webpack.git as that's a public repo we can all access and reproduce this issue with. tl;dr – I have no idea what the answer is yet and there is a lot of info in this issue. Here is a dump of what I know so far.
Q: Why would |
@JamieMason I think the I believe this is a red herring masking the original issue that myself and @yaroslavya had. |
Thanks @jesstelford, let's avoid angular2-webpack.git then in that case. Would someone mind creating a reduced test case which reproduces the issue please? I'm pretty lost and the OP expectation of "shrinkpack should get the files from the node_modules folder and put them under the node_shrinkwrap folder" is too broad in it's description to narrow down what's needed. Apologies if I'm missing something obvious here. |
My problem seems to be solved by fsevents/fsevents#141 (comment) 👍 |
Could you let me know how this goes please Yaroslav? |
@JamieMason Could not get to it yet. Will be able to check it out tomorrow and report the result here. Sorry for the delay. |
No problem at all @yaroslavya |
The npm version 3.10.5 worked just fine with preboot project. Didn't try the previous versions. Just in case anyone else has this problem I have a Windows 8 (didnt try it on win7 on which I had the initial issue). The issue was reproduced in absolutely the same way on win8. So I think that the latest npm version fixes it, so you can close it. |
Thanks for looking into this for us @yaroslavya, appreciate it. |
If reporting a bug, please use the following template.
Expected behaviour
shrinkpack should get the files from the node_modules folder and put them under the
node_shrinkwrap
folderActual behaviour
Steps to reproduce
Software versions used
Log output when running shrinkpack
Contents of your npm-shrinkwrap.json or package.json
yaroslavya-shrinkwrap.json.txt
The text was updated successfully, but these errors were encountered: