feat(versions): support npm: alias protocol

Closes #151
JamieMason · Jul 30, 2023 · 2a7ef86 · 2a7ef86
1 parent ce58e3a
commit 2a7ef86
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/instance/index.ts b/src/instance/index.ts
@@ -11,7 +11,7 @@ import type {
 } from 'npm-package-arg';
 import type { Strategy } from '../config/get-custom-types';
 import type { PackageJsonFile } from '../get-package-json-files/package-json-file';
-import type { Delete } from '../get-version-groups/lib/delete';
+import { DELETE, type Delete } from '../get-version-groups/lib/delete';
 import { $R } from '../lib/$R';
 
 /** Extends npm/npm-package-arg to support "workspace:*" */
@@ -88,7 +88,16 @@ export namespace Instance {
 
   /** An `Instance` whose specifier is eg "npm:imageoptim-cli@3.1.7" */
   export class AliasInstance extends Data.TaggedClass('AliasInstance')<BaseInstance<AliasResult>> {
-    setSpecifier = setSpecifier;
+    setSpecifier(version: string | Delete): void {
+      if (version === DELETE) {
+        setSpecifier.call(this, version);
+      } else {
+        const subSpec = this.parsedSpecifier.subSpec;
+        const name = subSpec.name || '';
+        const specifier = `npm:${name}@${version}`;
+        setSpecifier.call(this, specifier);
+      }
+    }
 
     getSemverSpecifier(): Option.Option<string> {
       const subSpec = this.parsedSpecifier.subSpec;

diff --git a/test/scenarios/version-groups/highest-semver-mismatch.spec.ts b/test/scenarios/version-groups/highest-semver-mismatch.spec.ts
@@ -22,7 +22,7 @@ describe('versionGroups', () => {
           ],
         },
       },
-      a: ['yarn@2.0.0', 'yarn@3.0.0'],
+      a: ['yarn@npm:yarn@2.0.0', 'yarn@npm:yarn@3.0.0'],
       b: ['yarn@3.0.0', 'yarn@3.0.0'],
     }).forEach((getScenario) => {
       describe('versionGroup.inspect()', () => {