test(fix-mismatches): clarify behaviour with non-semver mismatches

JamieMason · Jan 29, 2021 · 4fd1d0a · 4fd1d0a
1 parent 640cb7f
commit 4fd1d0a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 11 deletions.
diff --git a/src/commands/__snapshots__/fix-mismatches.spec.ts.snap b/src/commands/__snapshots__/fix-mismatches.spec.ts.snap
@@ -1,23 +1,39 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`fixMismatches ignores non-semver dependencies 1`] = `
+exports[`fixMismatches when dependencies are installed with different versions replaces non-semver dependencies with valid semver dependencies 1`] = `
 Array [
   Object {
     "contents": Object {
       "dependencies": Object {
-        "foo": "link:vendor/foo-0.1.0",
+        "foo": "0.3.0",
       },
     },
     "filePath": "/a/package.json",
   },
   Object {
     "contents": Object {
       "dependencies": Object {
-        "foo": "link:vendor/foo-0.2.0",
+        "foo": "0.3.0",
       },
     },
     "filePath": "/b/package.json",
   },
+  Object {
+    "contents": Object {
+      "dependencies": Object {
+        "foo": "0.3.0",
+      },
+    },
+    "filePath": "/c/package.json",
+  },
+  Object {
+    "contents": Object {
+      "dependencies": Object {
+        "foo": "0.3.0",
+      },
+    },
+    "filePath": "/d/package.json",
+  },
 ]
 `;
 

diff --git a/src/commands/fix-mismatches.spec.ts b/src/commands/fix-mismatches.spec.ts
@@ -34,14 +34,16 @@ describe('fixMismatches', () => {
         expect(wrappers).toMatchSnapshot();
       });
     });
-  });
 
-  it('ignores non-semver dependencies', () => {
-    const wrappers = [
-      mock.wrapper('a', ['foo@link:vendor/foo-0.1.0']),
-      mock.wrapper('b', ['foo@link:vendor/foo-0.2.0']),
-    ];
-    fixMismatches(wrappers, DEFAULT_CONFIG);
-    expect(wrappers).toMatchSnapshot();
+    it('replaces non-semver dependencies with valid semver dependencies', () => {
+      const wrappers = [
+        mock.wrapper('a', ['foo@link:vendor/foo-0.1.0']),
+        mock.wrapper('b', ['foo@link:vendor/foo-0.2.0']),
+        mock.wrapper('c', ['foo@0.3.0']),
+        mock.wrapper('d', ['foo@0.2.0']),
+      ];
+      fixMismatches(wrappers, DEFAULT_CONFIG);
+      expect(wrappers).toMatchSnapshot();
+    });
   });
 });