Fix default source overriding config file

JamieMason · Feb 22, 2023 · 65cc7c6 · 65cc7c6
1 parent 2f1ffba
commit 65cc7c6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/get-context/get-config/get-config.spec.ts b/src/get-context/get-config/get-config.spec.ts
@@ -140,7 +140,7 @@ describe('semverRange', () => {
 });
 
 describe('source', () => {
-  it('uses default when not set', () => {
+  it('defaults to [] when not set', () => {
     const disk = mockDisk();
     const config = getConfig(disk, {});
     expect(R.getExn(config).source).toEqual([]);

diff --git a/src/get-context/get-config/index.ts b/src/get-context/get-config/index.ts
@@ -42,7 +42,7 @@ function unSafeGetConfig(
     semverRange: getConfigByName('semverRange'),
     sortAz: getConfigByName('sortAz'),
     sortFirst: getConfigByName('sortFirst'),
-    source: getConfigByName('source'),
+    source: getConfigByName('source', []),
     types: fromCli?.types,
     versionGroups: getConfigByName('versionGroups'),
   });
@@ -78,10 +78,12 @@ function unSafeGetConfig(
 
   return allConfig;
 
-  function getConfigByName(name: keyof Syncpack.Config.Public): unknown {
+  function getConfigByName(name: keyof Syncpack.Config.Public, defaultValue?: any): unknown {
     if (typeof (fromCli as any)[name] !== 'undefined')
       return (fromCli as Syncpack.Config.Public)[name];
     if (typeof (fromRcFile as any)[name] !== 'undefined')
       return (fromRcFile as Syncpack.Config.Public)[name];
+    if (defaultValue)
+      return defaultValue
   }
 }
diff --git a/src/option.ts b/src/option.ts
@@ -19,7 +19,6 @@ export const option = {
     '-s, --source [pattern]',
     'glob pattern for package.json files to read from',
     collect,
-    [] as string[],
   ],
   types: [
     '-t, --types <names>',