Enhancement: Run tests against lowest, locked, and highest dependencies #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
localheinz
force-pushed
the
feature/dependencies
branch
from
0bfed15
to
ae9a67e
Compare
localheinz
commented
Jul 10, 2018
| - composer validate | ||
| stages: | ||
| - stan | ||
| - test |
There was a problem hiding this comment.
This makes the order in which we want to run the stages explicit.
| - composer update --prefer-dist --prefer-stable --no-interaction | ||
| jobs: | ||
| include: | ||
| - stage: Stan |
There was a problem hiding this comment.
We don't want to bother running the tests if running phpstan already fails.
| script: | ||
| - vendor/bin/phpstan analyse -l max -c phpstan.neon src tests | ||
|
|
||
| - &TEST |
There was a problem hiding this comment.
This creates an anchor, which we can later reference and extend from.
| script: | ||
| - vendor/bin/phpunit | ||
|
|
||
| - <<: *TEST |
There was a problem hiding this comment.
Here (and below) we extend from the previously declared anchor.
|
|
||
| - <<: *TEST | ||
|
|
||
| php: 7.0 |
There was a problem hiding this comment.
We override the PHP version.
| jobs: | ||
| include: | ||
| - stage: Test | ||
| php: 7.0 |
There was a problem hiding this comment.
This is what I mean in #17, the indentation is just off.
There was a problem hiding this comment.
Thanks, this makes it more obvious.
|
Thank you, @Jan0707! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
stanandtest) and runs tests against lowest, locked, and highest versions of dependenciesFollows #9 (comment).
💁♂️ For reference, see https://docs.travis-ci.com/user/build-stages/.