Consideration for removing the space at the end of Upstream icons #4774
jreilly-lukava
started this conversation in
General
Replies: 1 comment 1 reply
-
@jreilly-lukava fair point. Mind creating a PR for this? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
oh-my-posh/src/segments/git.go
Lines 495 to 500 in a8f97f5
Just my opinion I guess, but including the space by default seems counter intuitive. I think it should just be the icon and then the user can add a space if they want one. This looks especially odd when using it in a url with a terminal that highlights them.
Looks bad IMO:
![image](https://private-user-images.githubusercontent.com/30353736/312931443-c7e789d7-9dcb-453f-ac88-e26b7cac5add.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NjIwMDYsIm5iZiI6MTcyMTc2MTcwNiwicGF0aCI6Ii8zMDM1MzczNi8zMTI5MzE0NDMtYzdlNzg5ZDctOWRjYi00NTNmLWFjODgtZTI2YjdjYWM1YWRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE5MDgyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAzODA0YWZmY2Y3ZDU2YTIwNDQ4ZTIyZjNjMjY3MjM3MjQyNTllMGYyMmY5Zjg1MTFjMGE0OGUwMTFkYzJmZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yEwfzR8x7mlgtWARU9jHQT6adt7wd9GS2YVUtdEeRAg)
Looks good:
![image](https://private-user-images.githubusercontent.com/30353736/312931250-c8f7f30b-edca-4331-ab3e-23862c17178d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NjIwMDYsIm5iZiI6MTcyMTc2MTcwNiwicGF0aCI6Ii8zMDM1MzczNi8zMTI5MzEyNTAtYzhmN2YzMGItZWRjYS00MzMxLWFiM2UtMjM4NjJjMTcxNzhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE5MDgyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkMzgzMTk3YTQxODQwYzhjODAyMzA1ZDU2MGVhNmM4ZDExMTk3NDc0OTAxYTZhZjFiNzk3Njk4YWVmZGY0ZmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eYL9RghAQ4iX_WQV1XRQ3m7Dd_XHKle0mODbhxp0eCA)
Beta Was this translation helpful? Give feedback.
All reactions