Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal embedded in vscode does not display correct color after 3.47.3 #213

Closed
2 tasks done
Vixb1122 opened this issue Dec 2, 2020 · 2 comments
Closed
2 tasks done
Labels
👯‍♀️ duplicate This issue or pull request already exists

Comments

@Vixb1122
Copy link
Contributor

Vixb1122 commented Dec 2, 2020

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

Terminal embedded in vscode does not display correct color after 3.47.3.

Environment

  • Oh my Posh version: 3.47.3
  • Theme: material
  • Operating System: Windows 10
  • Shell: Powershell
  • Terminal: vscode

Steps to Reproduce

  1. Reinstall 3.47.3 and config it
  2. open terminal in vscode
  3. change theme to material
  4. toggle terminal panel size

Expected behavior: [What you expected to happen]
image

Actual behavior: [What actually happened]

  1. before toggle panel size
    image
  2. after toggle panel size
    image
@JanDeDobbeleer
Copy link
Owner

2 issues: vscode can't handle inverted ANSI (that's a bug on their end, see #182). And the toggle size is something I have no idea where it comes from but it also ANSI related (#211).

@JanDeDobbeleer
Copy link
Owner

@Vixb1122 the inverted ANSI will be gone so that should bring most things back to normal (#214). I'm closing this as a duplicate.

@JanDeDobbeleer JanDeDobbeleer added the 👯‍♀️ duplicate This issue or pull request already exists label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯‍♀️ duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants