fix: check permissions before attempting chmod #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanDeDobbeleer
requested changes
Jan 21, 2021
RobCannon
commented
Jan 21, 2021
JanDeDobbeleer
requested changes
Jan 22, 2021
| $hasExecutable = $permissions[3] -eq 'x' | ||
| if ($hasWrite -and -not $hasExecutable) { | ||
| Invoke-Expression -Command "chmod g+x $executable" | ||
| } |
There was a problem hiding this comment.
Return here as well, and the else can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
CONTRIBUTINGguideDescription
On a linux system, when you import the powershell module that was installed for AllUsers, the current user will usually not have the permissions to change the executable permission on the executable. That returns an error every time the module is imported.
This fix will check to see if the executable permission is already set and skip running chmod. It will also make sure the current user has the correct permissions to change the executable permissions before attempting to run chmod. If the module is installed by a sudo user, as long as the module is imported by that user, the file permissions will get set correctly.