[add_clone_worksheet] fix comments. closes #658

JanMarvin · Jun 22, 2023 · 7266426 · 7266426
1 parent 785e41a
commit 7266426
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/R/class-workbook.R b/R/class-workbook.R
@@ -944,7 +944,7 @@ wbWorkbook <- R6::R6Class(
       }
 
       if (length(cmt_id)) {
-        self$append("comments", self$comments[[cmt_id]])
+        self$append("comments", self$comments[cmt_id])
         self$worksheets[[old]]$relships$comments <- length(self$comments)
       }
 

diff --git a/tests/testthat/test-cloneWorksheet.R b/tests/testthat/test-cloneWorksheet.R
@@ -104,3 +104,17 @@ test_that("copy cells", {
   expect_equal(unlist(t(dat)), unlist(got), ignore_attr = TRUE)
 
 })
+
+test_that("cloning comments works", {
+
+  tmp <- temp_xlsx()
+
+  c1 <- create_comment(text = "this is a comment",  author = "")
+
+  # cloning comments from loaded worksheet did not work
+  wb <- wb_workbook()$add_worksheet()$add_comment(dims = "A1", comment = c1)$save(tmp)
+  wb <- wb_load(tmp)$clone_worksheet()
+
+  expect_equal(wb$comments[[1]][[1]]$ref, wb$comments[[2]][[1]]$ref)
+
+})