Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/writeData2] add hash_id for formats #102

Merged
merged 7 commits into from
Mar 21, 2022
Merged

[R/writeData2] add hash_id for formats #102

merged 7 commits into from
Mar 21, 2022

Conversation

JanMarvin
Copy link
Owner

The idea is solid, the coding still needs improvements.

I have tried to avoid calling and creating the same formats by adding some hash string. This might blow up the number of formats, but it shouldn't really matter for us. Unfortunately it didn't fix that initial error.

@JanMarvin
Copy link
Owner Author

JanMarvin commented Mar 21, 2022

Codecov Report

Merging #102 (af4b8a4) into main (6854b22) will decrease coverage by 0.20%.
The diff coverage is 29.34%.

❗ Current head af4b8a4 differs from pull request most recent head 849c55f. Consider uploading reports for the commit 849c55f to get more accurate results

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   51.37%   51.17%   -0.21%     
==========================================
  Files          42       42              
  Lines        8349     8411      +62     
==========================================
+ Hits         4289     4304      +15     
- Misses       4060     4107      +47     
Impacted Files Coverage Δ
R/wb_styles.R 37.65% <0.00%> (-0.16%) ⬇️
R/wb_functions.R 85.61% <31.64%> (-7.42%) ⬇️
R/class-style_mgr.R 71.96% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6854b22...849c55f. Read the comment docs.

@JanMarvin
Copy link
Owner Author

maybe it's fixed now, but I'm currently on a ferry and commit via mobile browser 🤓

@JanMarvin JanMarvin merged commit ab981ab into main Mar 21, 2022
@JanMarvin JanMarvin deleted the fmt_hashid branch March 23, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant