Update rc-cleanup #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be incorporated and tested later
tests haven't failed
TODOs should get cleaned-up
* bulk of function moved to Workbook$saveWorkbook * starts new wrapper wb_save_workbook * class function now returns .self * output path is retrieved separately * deprecated returnValue -- failure to copy file sends error
object previously returned added to fields
no need for this to be a Workbook method
* corrects assert_style() * adds package option * updates class checks for package * adds all enhancements for classes
* moves bulk of style creation to Style$new() * adds validators for readability * adds better default options that work with match.arg()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9 (correct #11)
Updating
rc-cleanupbranch with its dev branch. Had made some error somewhere and did more work with it fixed. This is to clean up the two branches.Will be making a PR
main<-rc-cleanupafterwards to merge the larger updates (files renamed, chunk of code removed)