Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/loadWorkbook] Fix reading external links #125

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Conversation

JanMarvin
Copy link
Owner

Fix reading a few chartsheet entries of minor importance as well.

@JanMarvin
Copy link
Owner Author

JanMarvin commented Apr 6, 2022

Codecov Report

Merging #125 (b91dacc) into main (4931ed2) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   60.17%   60.34%   +0.16%     
==========================================
  Files          39       39              
  Lines        7307     7315       +8     
==========================================
+ Hits         4397     4414      +17     
+ Misses       2910     2901       -9     
Impacted Files Coverage Δ
R/loadWorkbook.R 91.81% <100.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4931ed2...b91dacc. Read the comment docs.

@JanMarvin JanMarvin merged commit 67debab into main Apr 7, 2022
@JanMarvin JanMarvin deleted the externalLinks branch April 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant