Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 set header footer #144

Merged
merged 4 commits into from
Apr 25, 2022
Merged

75 set header footer #144

merged 4 commits into from
Apr 25, 2022

Conversation

jmbarbone
Copy link
Collaborator

related to #75

@JanMarvin
Copy link
Owner

JanMarvin commented Apr 23, 2022

Codecov Report

Merging #144 (8096866) into main (cadca24) will increase coverage by 0.38%.
The diff coverage is 85.00%.

❗ Current head 8096866 differs from pull request most recent head 2819465. Consider uploading reports for the commit 2819465 to get more accurate results

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   71.40%   71.78%   +0.38%     
==========================================
  Files          37       37              
  Lines        7203     7206       +3     
==========================================
+ Hits         5143     5173      +30     
+ Misses       2060     2033      -27     
Impacted Files Coverage Δ
R/class-workbook.R 66.37% <81.25%> (+0.16%) ⬆️
R/class-workbook-wrappers.R 50.00% <100.00%> (+3.26%) ⬆️
R/dates.R 90.90% <0.00%> (ø)
R/helperFunctions.R 79.20% <0.00%> (ø)
R/class-workbook-utils.R 96.36% <0.00%> (+0.20%) ⬆️
R/utils.R 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadca24...2819465. Read the comment docs.

@JanMarvin
Copy link
Owner

👍

@JanMarvin
Copy link
Owner

let me know if it helps if I rebase open pull requests

@JanMarvin
Copy link
Owner

And another one rebased and merged! At least I have to look at the expect_wrapper code to understand what is going on :)

@JanMarvin JanMarvin merged commit dac95c4 into main Apr 25, 2022
@jmbarbone jmbarbone deleted the 75-set-header-footer branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants