Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 add image plot #145

Merged
merged 10 commits into from
Apr 26, 2022
Merged

75 add image plot #145

merged 10 commits into from
Apr 26, 2022

Conversation

jmbarbone
Copy link
Collaborator

related to #75

works on wb_add_plot() and wb_add_image(). These ones took a bit more work and now wbWorkbook$add_plot() is now a more direct wrapper for wbWorkbook$add_image(). The testing is a little weird though and probably requires a bit more work for expect_wrapper() to be more certain.

@JanMarvin JanMarvin mentioned this pull request Apr 26, 2022
@JanMarvin
Copy link
Owner

Codecov Report

Merging #145 (a14b9b1) into main (568d550) will increase coverage by 1.04%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   71.77%   72.81%   +1.04%     
==========================================
  Files          37       37              
  Lines        7220     7250      +30     
==========================================
+ Hits         5182     5279      +97     
+ Misses       2038     1971      -67     
Impacted Files Coverage Δ
R/class-workbook.R 68.91% <30.15%> (+1.58%) ⬆️
R/class-workbook-wrappers.R 50.19% <50.00%> (+4.40%) ⬆️
R/expect-wrapper.R 69.86% <100.00%> (+0.41%) ⬆️
R/baseXML.R 84.69% <0.00%> (+7.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568d550...a14b9b1. Read the comment docs.

@JanMarvin JanMarvin merged commit 297d88a into main Apr 26, 2022
@JanMarvin
Copy link
Owner

Note: the plot tests only complete in interactive R sessions, such as in RStudio.
Otherwise rebased and merged this PR as well!

@jmbarbone jmbarbone deleted the 75-add-image-plot branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants