75 page setup #146
75 page setup #146
Conversation
| op <- openxlsx_options() | ||
| on.exit(options(op), add = TRUE) | ||
|
|
||
| wb_page_setup <- function( |
There was a problem hiding this comment.
just for reference: I named it ws_ because it's impacting only a single worksheet and not an entire workbook.
There was a problem hiding this comment.
Ah, I see. I think right now the wb_ prefix denotes three main things:
- first param is a
wbWorkbook - the
wbWorkbookobject is altered - the
wbWorkbookobject is returned
A ws_ prefix would make sense, to me, if this accepted, altered, and returned a wbWorksheet object rather than the wbWorkbook object.
wb <-
wb_workbook() |>
wb_add_worksheet("a") |>
wb_page_setup("a", ...)
ws <-
# but here the wb_ prefix creates and returns the ws object...
wb_worksheet() |>
ws_page_setup()
wb <-
wb_workbook() |>
wb_add_worksheet(ws)There was a problem hiding this comment.
I agree, it's just why I named it the way I did. My last defence: you didn't stop me :)
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 72.81% 72.87% +0.05%
==========================================
Files 37 37
Lines 7250 7266 +16
==========================================
+ Hits 5279 5295 +16
Misses 1971 1971
Continue to review full report at Codecov.
|
|
Another-one in! |
related to #75
A few smaller fixes, too