-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DESCRIPTION] Version bump. closes #150 #151
Conversation
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 73.20% 73.20%
=======================================
Files 37 37
Lines 7273 7273
=======================================
Hits 5324 5324
Misses 1949 1949 Continue to review full report at Codecov.
|
Once you merge this PR @jmbarbone , I'll set the repo to public. I don't see us writing epic documentation over the upcoming weekend 😜 |
🎉 Alright, I'm done for |
Do I have the green light, @jmbarbone ? Or is there anything you want to look at prior the version bump? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to start the public release version at 0.2.0
or 0.1.0
?
Although I don't suppose that we'd promise a stable API until later we'll probably have to be nice enough to add some warnings and notes about deprecation. I might prefer to finish up the bulk of #75 but I suppose we're fine with suggesting that these first releases are just for testing.
@@ -1,7 +1,7 @@ | |||
Type: Package | |||
Package: openxlsx2 | |||
Title: Read, Write and Edit xlsx Files | |||
Version: 0.0.1 | |||
Version: 0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 0.1.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, I thought 0.2.0 was the milestone we passed, but either is fine with me
I'd like to go public rather soon.
Until the CRAN release I doubt anyone will seriously start adding the package to their prod pipelines? For CRAN I'd like to have a stable API, but currently I would just say "here, we have been working hard and it's still a lot to do, but you can have a first look." Though if you prefer to do #75 first, I understand too. I just don't want to postpone until eternity (given that we will be finished prior to the end of time 😄) |
@JanMarvin , if I counted right, there may only be 3 more workbook wrappers to transition into the |
Woohoo! 🚀 I've played around with wb_write_data, but that needs some more work (I'd like to cleanup writeData, writeDataTable, writeData2 and update_cell, but that needs time of which I'm short of at the moment; and most likely it will need someone with better knowledge of R6 than me looking at you 😀). The styles mgr is a locked environment and my wrapper throws a strange warning, but that's something for the future. |
Merged #166 and fixed a few things here and there. Most likely there will be other things popping up like mushrooms, but it is what it is :) |
We are public (🚀) and |
Order Imports and Suggests, increase minimal R version (this is the highest R version requested by our imports).