Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESCRIPTION] Version bump. closes #150 #151

Merged
merged 2 commits into from
May 9, 2022
Merged

[DESCRIPTION] Version bump. closes #150 #151

merged 2 commits into from
May 9, 2022

Conversation

JanMarvin
Copy link
Owner

Order Imports and Suggests, increase minimal R version (this is the highest R version requested by our imports).

@JanMarvin
Copy link
Owner Author

JanMarvin commented Apr 29, 2022

Codecov Report

Merging #151 (a3938ee) into main (ac2041f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          37       37           
  Lines        7273     7273           
=======================================
  Hits         5324     5324           
  Misses       1949     1949           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2041f...a3938ee. Read the comment docs.

@JanMarvin
Copy link
Owner Author

Once you merge this PR @jmbarbone , I'll set the repo to public. I don't see us writing epic documentation over the upcoming weekend 😜

@JanMarvin
Copy link
Owner Author

🎉 Alright, I'm done for 0.0.1! 🥳

@JanMarvin
Copy link
Owner Author

Do I have the green light, @jmbarbone ? Or is there anything you want to look at prior the version bump?

Copy link
Collaborator

@jmbarbone jmbarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start the public release version at 0.2.0 or 0.1.0?

Although I don't suppose that we'd promise a stable API until later we'll probably have to be nice enough to add some warnings and notes about deprecation. I might prefer to finish up the bulk of #75 but I suppose we're fine with suggesting that these first releases are just for testing.

@@ -1,7 +1,7 @@
Type: Package
Package: openxlsx2
Title: Read, Write and Edit xlsx Files
Version: 0.0.1
Version: 0.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 0.1.0?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, I thought 0.2.0 was the milestone we passed, but either is fine with me

NEWS.md Show resolved Hide resolved
@JanMarvin
Copy link
Owner Author

Do we want to start the public release version at 0.2.0 or 0.1.0?

Although I don't suppose that we'd promise a stable API until later we'll probably have to be nice enough to add some warnings and notes about deprecation. I might prefer to finish up the bulk of #75 but I suppose we're fine with suggesting that these first releases are just for testing.

I'd like to go public rather soon.

  • we finally have something to show
  • we get feedback

Until the CRAN release I doubt anyone will seriously start adding the package to their prod pipelines? For CRAN I'd like to have a stable API, but currently I would just say "here, we have been working hard and it's still a lot to do, but you can have a first look." Though if you prefer to do #75 first, I understand too. I just don't want to postpone until eternity (given that we will be finished prior to the end of time 😄)

@jmbarbone
Copy link
Collaborator

@JanMarvin , if I counted right, there may only be 3 more workbook wrappers to transition into the wbWorkbook object (i.e., page breaks, ungroup cols, ungroup rows). Once those are done, I'd be happy with the current state for the public release.

@JanMarvin
Copy link
Owner Author

Woohoo! 🚀

I've played around with wb_write_data, but that needs some more work (I'd like to cleanup writeData, writeDataTable, writeData2 and update_cell, but that needs time of which I'm short of at the moment; and most likely it will need someone with better knowledge of R6 than me looking at you 😀). The styles mgr is a locked environment and my wrapper throws a strange warning, but that's something for the future.

@JanMarvin
Copy link
Owner Author

Alright, #163 #162 and #157 are all in. Any more showstoppers of which we are aware?

@jmbarbone
Copy link
Collaborator

Alright, #163 #162 and #157 are all in. Any more showstoppers of which we are aware?

After #166 I won't have any hanging issues for the first release.

@JanMarvin
Copy link
Owner Author

Merged #166 and fixed a few things here and there. Most likely there will be other things popping up like mushrooms, but it is what it is :)

@JanMarvin JanMarvin merged commit f9959be into main May 9, 2022
@JanMarvin JanMarvin deleted the v020_bump branch May 9, 2022 06:59
@JanMarvin
Copy link
Owner Author

We are public (🚀) and pkgdown is now available. I'll head for breakfast until my hotel decides it's to late for coffee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants