Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R/various] renaming R functions pt3 #155

Merged
merged 3 commits into from
Apr 30, 2022
Merged

[R/various] renaming R functions pt3 #155

merged 3 commits into from
Apr 30, 2022

Conversation

JanMarvin
Copy link
Owner

conditionalFormatting -> wb_conditional_formatting
convertToDate -> convert_date
convertToDateTime -> convert_datetime
createComment -> create_comment
deleteData -> delete_data
makeHyperlinkString -> create_hyperlink
removeComment -> remove_comment
writeComment -> write_comment
writeCommentXML -> write_comment_xml
writeData -> write_data
writeData2 -> write_data2
writeDataTable -> write_datatable
writeFormula -> write_formula

@JanMarvin
Copy link
Owner Author

Codecov Report

Merging #155 (43e9c2f) into main (ac2041f) will not change coverage.
The diff coverage is 72.22%.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          37       37           
  Lines        7273     7273           
=======================================
  Hits         5324     5324           
  Misses       1949     1949           
Impacted Files Coverage Δ
R/class-comment.R 77.08% <ø> (ø)
R/class-workbook-wrappers.R 47.71% <ø> (ø)
R/get-named-regions.R 90.00% <ø> (ø)
R/helperFunctions.R 79.20% <ø> (ø)
R/openxlsx2Coerce.R 9.80% <0.00%> (ø)
R/readWorkbook.R 95.74% <ø> (ø)
R/wb_styles.R 47.25% <ø> (ø)
R/xl_open.R 0.00% <ø> (ø)
R/writeDataTable.R 73.86% <33.33%> (ø)
R/writeData.R 74.50% <50.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2041f...43e9c2f. Read the comment docs.

@JanMarvin JanMarvin merged commit 702448d into main Apr 30, 2022
@JanMarvin JanMarvin deleted the rename_functions_pt3 branch April 30, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant