Empty cell information #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 77.74% 77.71% -0.04%
==========================================
Files 36 36
Lines 7424 7414 -10
==========================================
- Hits 5772 5762 -10
Misses 1652 1652
Continue to review full report at Codecov.
|
…tead of "_openxlsx_NA_" as before. Previously this variable was used to help various `wbWorkbook` functions to distinguish between empty cells, missing cells and cells to be ignored. Fortunately, this is no longer needed. Either a cell contains useful information or it can be ignored. Empty strings are written as `<is><t></t></is>` or they are still sharedstrings. Row and column information cannot be empty, similarly openxml has no empty attributes (as far as I know). This relieves us of the time-consuming burden of initializing each field of cc with the long string "_openxlsx_NA_" (it was intentionally that long to prevent someone from randomly selecting it in an xlsx file). However, since this string was used fundamentally in several places, this change should be monitored closely. Especially for files that are known to be strange (missing lines, missing data, empty strings, or uninitialized cells). There is another string called "_openxlsx_NA". This string has another use that is still required, and writing this string from openxlsx2 will still corrupt the workbook as indicated in the description.
JanMarvin
force-pushed
the
empty_cell_information
branch
from
695af47
to
2b8be90
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[c++/empty cells] Empty cell information is now displayed with "" instead of "openxlsx_NA" as before. Previously this variable was used to help various
wbWorkbookfunctions to distinguish between empty cells, missing cells and cells to be ignored. Fortunately, this is no longer needed. Either a cell contains useful information or it can be ignored. Empty strings are written as<is><t></t></is>or they are still sharedstrings. Row and column information cannot be empty, similarly openxml has no empty attributes (as far as I know).This relieves us of the time-consuming burden of initializing each field of cc with the long string "openxlsx_NA" (it was intentionally that long to prevent someone from randomly selecting it in an xlsx file). However, since this string was used fundamentally in several places, this change should be monitored closely. Especially for files that are known to be strange (missing lines, missing data, empty strings, or uninitialized cells).
There is another string called "_openxlsx_NA". This string has another use that is still required, and writing this string from openxlsx2 will still corrupt the workbook as indicated in the description.
This is more of a heads up for you on who to blame @jmbarbone, I don't expect any negative effects from this PR (just positive, cleaner
cctable and slight speedups due to skipping the initialization, and our tests and verifications have indicated no problem 😃 ).